[
https://issues.apache.org/jira/browse/YARN-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690997#comment-15690997
]
Daniel Templeton commented on YARN-5890:
----------------------------------------
Thanks, [~yufeigu]. Minor points on the tests:
* {{queueFSNoneZero}} should be {{queueFSNonZero}}.
* Since max AM share isn't being set explicitly, it might be a good idea to add
a comment stating what it you expect the default to be. It doesn't really
affect anything, but as a reader of the code, it's the first question that
comes to mind.
* I'd love to see some messages on all those asserts.
* I know that none of the methods here change {{amResource}}, but since
{{Resource}} is mutable, I'd feel better if we created a new one for each part
of the test rather than reusing the same {{amResource}}.
> FairScheduler should log information about AM-resource-usage and max-AM-share
> for queues
> ----------------------------------------------------------------------------------------
>
> Key: YARN-5890
> URL: https://issues.apache.org/jira/browse/YARN-5890
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Attachments: YARN-5890.001.patch, YARN-5890.002.patch
>
>
> There are several cases where jobs in a queue or stuck likely because of
> maxAMShare. It is hard to debug these issues without any information.
> At the very least, we need to log both AM-resource-usage and max-AM-share for
> queues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
