[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15781991#comment-15781991 ]
Karthik Kambatla commented on YARN-5830: ---------------------------------------- [~yufeigu], thanks for working on this. The patch seems to introduce potentialContainers to track a potential set of containers that includes an AM container as we consider multiple nodes. But, I am a little confused by how we handle if we encounter an AM container. Can you explain your high-level approach? I haven't looked closely, but other minor comments: # In the same method, I seemed to have forgotten a TODO (KK) item. Mind creating a follow-up jira and annotating the TODO with that jira instead of my initials? Thanks. # Instead of introducing a new list (containersAMLast), can we just use containersToCheck? May be, remove AM containers first and then add them all at the end? # I think I saw a couple of typos too. > Avoid preempting AM containers > ------------------------------ > > Key: YARN-5830 > URL: https://issues.apache.org/jira/browse/YARN-5830 > Project: Hadoop YARN > Issue Type: Sub-task > Components: fairscheduler > Reporter: Karthik Kambatla > Assignee: Yufei Gu > Attachments: YARN-5830.001.patch > > > While considering containers for preemption, avoid AM containers unless > absolutely necessary. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org