[
https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827715#comment-15827715
]
Yufei Gu commented on YARN-5830:
--------------------------------
Thanks [~kasha] for the detailed review. Uploaded patch 005 for your comments.
The following code seems like buggy since when we invoking
{{scheduler.completedContainer(}} in {{PreemptContainersTask}}, it will release
the resources from the containers preempted, but these resources cannot be
preempted again. We can file another JIRA for it. Also for that case, I remove
one of my unit tests in this JIRA because it will fail because of this issue.
{code}
Resource potential = Resources.clone(node.getUnallocatedResource());
{code}
> Avoid preempting AM containers
> ------------------------------
>
> Key: YARN-5830
> URL: https://issues.apache.org/jira/browse/YARN-5830
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Reporter: Karthik Kambatla
> Assignee: Yufei Gu
> Attachments: YARN-5830.001.patch, YARN-5830.002.patch,
> YARN-5830.003.patch, YARN-5830.004.patch, YARN-5830.005.patch
>
>
> While considering containers for preemption, avoid AM containers unless
> absolutely necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
