[ 
https://issues.apache.org/jira/browse/YARN-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863264#comment-15863264
 ] 

Sunil G commented on YARN-6156:
-------------------------------

Few more comments:
- {{getAmNodeLabelExpression}} could return null in case of unmanaged AM also. 
I think you can have a public API to get a cleaner AM Node Label expression  
(from AM resource request, and handle error cases as well). Ideally we should 
not get a null from that api.
- I agree that non-exclusive nodes are bounded by available resources. However 
if some resource are obtained from any such node, we have to increase and 
update nodes count to SimpleBlacklistManager and then decrease node count when 
resources are removed. But i do agree that it may not be that straight forward 
to handle this. [~bibinchundatt] Could you please check and share your 
observations on this point.



> AM blacklistdisableThreshold  consider node partition count
> -----------------------------------------------------------
>
>                 Key: YARN-6156
>                 URL: https://issues.apache.org/jira/browse/YARN-6156
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: YARN-6156.0001.patch
>
>
> As per the current implementation for AM blacklisting disabling is based on 
> completed custer resource.
> Incase of partitioned cluster, nodes applicable for AM labels only should be 
> considered as total nodes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to