[
https://issues.apache.org/jira/browse/YARN-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945941#comment-15945941
]
Haibo Chen commented on YARN-6329:
----------------------------------
Thanks [~vbertschinger] for the patch! +1 nonbinding.
> Remove unnecessary TODO comment from AppLogAggregatorImpl.java
> --------------------------------------------------------------
>
> Key: YARN-6329
> URL: https://issues.apache.org/jira/browse/YARN-6329
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.8.0
> Reporter: Akira Ajisaka
> Assignee: victor bertschinger
> Priority: Minor
> Labels: newbie
> Attachments: YARN-6329.001.patch
>
>
> After YARN-3116, this TODO comment is unnecessary.
> {code}
> // TODO: The condition: containerId.getId() == 1 to determine an AM
> container
> // is not always true.
> private boolean shouldUploadLogs(ContainerLogContext logContext) {
> return logAggPolicy.shouldDoLogAggregation(logContext);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
