[ https://issues.apache.org/jira/browse/YARN-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946401#comment-15946401 ]
Hudson commented on YARN-6329: ------------------------------ SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11485 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11485/]) YARN-6329. Remove unnecessary TODO comment from (aajisaka: rev 82fb9ce8df7a534a4cbcec624d7b6c0b33e79123) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java > Remove unnecessary TODO comment from AppLogAggregatorImpl.java > -------------------------------------------------------------- > > Key: YARN-6329 > URL: https://issues.apache.org/jira/browse/YARN-6329 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 2.8.0 > Reporter: Akira Ajisaka > Assignee: victor bertschinger > Priority: Minor > Labels: newbie > Fix For: 2.9.0, 3.0.0-alpha3 > > Attachments: YARN-6329.001.patch > > > After YARN-3116, this TODO comment is unnecessary. > {code} > // TODO: The condition: containerId.getId() == 1 to determine an AM > container > // is not always true. > private boolean shouldUploadLogs(ContainerLogContext logContext) { > return logAggPolicy.shouldDoLogAggregation(logContext); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org