[
https://issues.apache.org/jira/browse/YARN-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087233#comment-16087233
]
Rohith Sharma K S commented on YARN-4455:
-----------------------------------------
thanks [~varun_saxena] for working on this jira. Overall patch looks good to me
nits:
TimelineReaderWebServices.java
line 614
# printing whole stack trace. I think this should not be printed full message.
What is the necessity of it?
HBaseTimelineStorageUtils
# Just for curiosity, what are we writing and reading with supplemented
Timestamp ?
# Method setMetricsTimeRange has conditional statement in each line. Can it be
optimized by implicitly assuming that tsBegin will not be less than 0 since
TimelineDataManager validates it? Similarly for tsEnd?
> Support fetching metrics by time range
> --------------------------------------
>
> Key: YARN-4455
> URL: https://issues.apache.org/jira/browse/YARN-4455
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-5355
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: YARN-5355, yarn-5355-merge-blocker
> Attachments: YARN-4455-YARN-5355.01.patch,
> YARN-4455-YARN-5355.02.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
