[ 
https://issues.apache.org/jira/browse/YARN-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091246#comment-16091246
 ] 

Varun Saxena commented on YARN-4455:
------------------------------------

[~vrushalic], we do divide it by TS_MULTIPLIER while reading it back.

bq. I am wondering if this might be a concern for entity or application tables. 
When we multiply the timestamp by TimestampGenerator#TS_MULTIPLIER , I am 
wondering if the timestamp meaning is changing. Also if it will roll over and 
may not mean the right thing.
For example, if the metrics data was written with timestamp of today at 3pm, 
the multiplier will move it to another timestamp.
Refer to ColumnHelper#readResultsWithTimestamps where we call 
TimestampGenerator#getTruncatedTimestamp to divide the retrieved timestamp by 
1000.

> Support fetching metrics by time range
> --------------------------------------
>
>                 Key: YARN-4455
>                 URL: https://issues.apache.org/jira/browse/YARN-4455
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-5355
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: YARN-5355, yarn-5355-merge-blocker
>         Attachments: YARN-4455-YARN-5355.01.patch, 
> YARN-4455-YARN-5355.02.patch, YARN-4455-YARN-5355.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to