[
https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139157#comment-16139157
]
Xuan Gong commented on YARN-6876:
---------------------------------
Thanks for the review. [~djp]
bq. LogAggregationFileController.java is supposed to be a public interface so
third-party can implement its own log format. We should add public, unstable
annotation to the class. If we concern it is too early to get public, then we
should have a separated jira to track this effort when it is becoming more
stable.
Yes, it is too early to mark the API as public. For now, I prefer to mark the
APIs as private. And we can change them back to Public when the feature is more
stable. Created https://issues.apache.org/jira/browse/YARN-7089 to track this.
Other comments make sense to me. Uploaded a new patch to address them.
> Create an abstract log writer for extendability
> -----------------------------------------------
>
> Key: YARN-6876
> URL: https://issues.apache.org/jira/browse/YARN-6876
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-6876-branch-2.001.patch, YARN-6876-trunk.001.patch,
> YARN-6876-trunk.002.patch, YARN-6876-trunk.003.patch,
> YARN-6876-trunk.004.patch, YARN-6876-trunk.005.patch
>
>
> Currently, TFile log writer is used to aggregate log in YARN. We need to add
> an abstract layer, and pick up the correct log writer based on the
> configuration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
