[
https://issues.apache.org/jira/browse/YARN-5329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157893#comment-16157893
]
Carlo Curino commented on YARN-5329:
------------------------------------
Thanks @subru for the feedback.
# Regarding {{recurrenceExpression}} in {{PlanningAlgorithm}} it is never null
by design (see {{ReservationDefinitionPBImpl.getRecurrenceExpression()}} is set
to "0" if there is no recurrence), so I think the null check is redundant
(unless we assume other non-PBImpl implementations will be used in the future).
# This is not really a base tests, as we already had substantial tests in the
specific per-agents tests, which checks for specific corner cases. Migrating
those would be a delicate/painful, so this test was added, to provide a broader
"lots of noisy allocations" type experiments, which in my experience are good
to exercise a larger portion of the codebase and capture hard-to-spot
multi-reservation scenarios.
# done
Tests pass locally when YARN-5330 is applied (but lets see what YETUS says when
that one is in)
> ReservationAgent enhancements required to support recurring reservations in
> the YARN ReservationSystem
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-5329
> URL: https://issues.apache.org/jira/browse/YARN-5329
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Subru Krishnan
> Assignee: Carlo Curino
> Attachments: YARN-5329.v0.patch, YARN-5329.v1.patch,
> YARN-5329.v2.patch, YARN-5329.v3.patch
>
>
> YARN-5326 proposes adding native support for recurring reservations in the
> YARN ReservationSystem. This JIRA is a sub-task to track the changes required
> in ReservationAgent to accomplish it. Please refer to the design doc in the
> parent JIRA for details.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
