[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184640#comment-16184640
]
Jian He commented on YARN-7202:
-------------------------------
bq. If both mocked version of ServiceClient, and ApiServer are in agreement of
the behavior. The ambiguity problem must be originated from ServiceClient. This
verification confirms that unit test for ApiServer is done correctly, and
problem resides in ServiceClient.
It won't be easy to maintain the behavior to be consistent across
ServiceClientForTest and ServiceClient, because most of the time people will
not look at the UTs unless the UT failed.
Any way, I agree we can do the more end-to-end test separately.
Reg the UT patch, for the changes in updateService, I saw you tried to
Serialize all the operations and that introduced quite a few if/else
conditions. To keep it simple, for start and stop, we can just return directly？
it is expected to only do start or stop.
And the " // flex a single component app" scenario code will be removed later.
The TestApiServer introduced powermock. Till now, Hadoop had not been using
powermock, and is using Mockito. Some historical discussion HADOOP-7537,
HADOOP-9122 happened for this. To keep it consistent with rest code base and
less controversial, how about changing to use Mockito ? Or any part in the UT
must rely on powermock?
> End-to-end UT for api-server
> ----------------------------
>
> Key: YARN-7202
> URL: https://issues.apache.org/jira/browse/YARN-7202
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Attachments: YARN-7202.yarn-native-services.001.patch,
> YARN-7202.yarn-native-services.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
