[ 
https://issues.apache.org/jira/browse/YARN-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211799#comment-16211799
 ] 

Wangda Tan commented on YARN-7307:
----------------------------------

Thanks [~sunilg] for updating the patch, 

I'm fine with the last patch except 
DEFAULT_YARN_CLIENT_LOAD_RESOURCETYPES_FROM_SERVER should be false instead of 
true. Since applications need to update their implementation in order to use 
the feature, it's better to default opt-out the update resource types behavior 
in YarnClientImpl for safety.

Could you also check UT failures / java docs warnings?

> Revisit resource-types.xml loading behaviors
> --------------------------------------------
>
>                 Key: YARN-7307
>                 URL: https://issues.apache.org/jira/browse/YARN-7307
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>            Priority: Blocker
>         Attachments: YARN-7307.001.patch, YARN-7307.002.patch, 
> YARN-7307.003.patch
>
>
> Existing feature requires every client has a resource-types.xml in order to 
> use multiple resource types, should we allow client/AM update supported 
> resource types via Yarn APIs?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to