[
https://issues.apache.org/jira/browse/YARN-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223840#comment-16223840
]
Arun Suresh commented on YARN-4511:
-----------------------------------
Thanks for updating the patch [~haibochen]. I am able to follow this a bit
better.
Some Comments:
- In SchedulerNode, you are doing an if check inside
{{guaranteedContainerResourceAllocated}}, but you do not do the same in
{{opportunisticContainerResourceAllocated}}. Is there a case where the
'resource' argument might be null in the former method call (since that is only
case when the {{containerResourceAllocated}} method can return false)?
{code}
if (containerResourceAllocated(resource, allocatedResourceGuaranteed)) {
Resources.subtractFrom(unallocatedResource, resource);
}
{code}
- I see a similar pattern as above in {{guaranteedContainerResourceReleased}}
and {{opportunisticContainerResourceReleased}}
- Thank you for splitting numContainers into numGuaranteedContainers and
numAllocatedContainers, but then in the SchedulerNodeReport, shouldn't this.num
= numOpp + numGuaranteed ?
Everything else looks fine to me.
> Common scheduler changes supporting scheduler-specific implementations
> ----------------------------------------------------------------------
>
> Key: YARN-4511
> URL: https://issues.apache.org/jira/browse/YARN-4511
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Haibo Chen
> Attachments: YARN-4511-YARN-1011.00.patch,
> YARN-4511-YARN-1011.01.patch, YARN-4511-YARN-1011.02.patch,
> YARN-4511-YARN-1011.03.patch, YARN-4511-YARN-1011.04.patch,
> YARN-4511-YARN-1011.05.patch, YARN-4511-YARN-1011.06.patch,
> YARN-4511-YARN-1011.07.patch, YARN-4511-YARN-1011.08.patch,
> YARN-4511-YARN-1011.09.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
