[
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225778#comment-16225778
]
Daniel Templeton commented on YARN-7316:
----------------------------------------
I've actually been actively doing the opposite. It seems strange to me that we
should pass the calc object to {{Resources}} so that it can call the method for
us. It's harder to read, makes for longer lines that may need to be wrapped,
and creates unnecessary coupling. It's not like using {{Resources}} as a proxy
saves you from needing a calculator instance or does anything useful for you at
all, really.
What's the motivation for running all the calls through the {{Resources}}
object? It makes sense for some of the comparisons, where it's actually doing
something useful, but I don't get it for the rest of the calls.
> Cleaning up the usage of Resources and ResourceCalculator
> ---------------------------------------------------------
>
> Key: YARN-7316
> URL: https://issues.apache.org/jira/browse/YARN-7316
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 3.1.0
> Reporter: lovekesh bansal
> Assignee: lovekesh bansal
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: YARN-7316_trunk.001.patch
>
>
> Cleaning up and Uniformizing the usage the usage of Resources and
> ResourceCalculator.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
