[ 
https://issues.apache.org/jira/browse/YARN-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226937#comment-16226937
 ] 

lovekesh bansal commented on YARN-7316:
---------------------------------------

I think passing Resource calculator as an argument should have been included 
for some reason, not sure but might be scalability. Otherwise we could have 
initialized resource calculator in one single place, be it in {{Resources}} 
class or the calculator class. +1 for that we should have all operations on 
resources in one single class and but calling functions on calculator class 
seems unintuitive to me, Resources class seems appropriate for that purpose. 
What do you suggest?

> Cleaning up the usage of Resources and ResourceCalculator
> ---------------------------------------------------------
>
>                 Key: YARN-7316
>                 URL: https://issues.apache.org/jira/browse/YARN-7316
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 3.1.0
>            Reporter: lovekesh bansal
>            Assignee: lovekesh bansal
>            Priority: Minor
>             Fix For: 3.1.0
>
>         Attachments: YARN-7316_trunk.001.patch
>
>
> Cleaning up and Uniformizing the usage the usage of Resources and 
> ResourceCalculator.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to