[
https://issues.apache.org/jira/browse/YARN-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237297#comment-16237297
]
Sunil G commented on YARN-7159:
-------------------------------
Thanks [~maniraj...@gmail.com]
Few minor comments
# In {{ResourceUtils#addResourceInformation}}, else condition could be avoided.
Below code snippet could be common outside once *units* is updated inside if
conditions.
{code}
510 nodeResources.get(resourceType).setValue(resourceValue);
511 nodeResources.get(resourceType).setUnits(units);
{code}
# In {{MockNM}}, {{getResource}} could be more generic enough to get whats
should be the units and value for different resources.
# getRegNMResponse -> getRegisteredNMResponse
> Normalize unit of resource objects in RM and avoid to do unit conversion in
> critical path
> -----------------------------------------------------------------------------------------
>
> Key: YARN-7159
> URL: https://issues.apache.org/jira/browse/YARN-7159
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Wangda Tan
> Assignee: Manikandan R
> Priority: Critical
> Attachments: YARN-7159.001.patch, YARN-7159.002.patch,
> YARN-7159.003.patch, YARN-7159.004.patch, YARN-7159.005.patch,
> YARN-7159.006.patch, YARN-7159.007.patch, YARN-7159.008.patch,
> YARN-7159.009.patch, YARN-7159.010.patch, YARN-7159.011.patch
>
>
> Currently resource conversion could happen in critical code path when
> different unit is specified by client. This could impact performance and
> throughput of RM a lot. We should do unit normalization when resource passed
> to RM and avoid expensive unit conversion every time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
