[ https://issues.apache.org/jira/browse/YARN-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237740#comment-16237740 ]
Manikandan R commented on YARN-7159: ------------------------------------ 1,3: done. Also renamed getRegNMRequest -> getRegisteredNMRequest 2: Initially, created this method to use it in few other places, but then finally ended up in using in only 1 place. Hence removed method for now. Hope this is fine. 4. {{mvn test -Dtest=TestCapacitySchedulerPerf#testUserLimitThroughputForTwoResources -DRunCapacitySchedulerPerfTests=true}} Ran test and able to see successful execution. Report Summary is #ResourceTypes = 2. Avg of fastest 20: 42643.92 > Normalize unit of resource objects in RM and avoid to do unit conversion in > critical path > ----------------------------------------------------------------------------------------- > > Key: YARN-7159 > URL: https://issues.apache.org/jira/browse/YARN-7159 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager > Reporter: Wangda Tan > Assignee: Manikandan R > Priority: Critical > Attachments: YARN-7159.001.patch, YARN-7159.002.patch, > YARN-7159.003.patch, YARN-7159.004.patch, YARN-7159.005.patch, > YARN-7159.006.patch, YARN-7159.007.patch, YARN-7159.008.patch, > YARN-7159.009.patch, YARN-7159.010.patch, YARN-7159.011.patch, > YARN-7159.012.patch > > > Currently resource conversion could happen in critical code path when > different unit is specified by client. This could impact performance and > throughput of RM a lot. We should do unit normalization when resource passed > to RM and avoid expensive unit conversion every time. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org