[
https://issues.apache.org/jira/browse/YARN-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256633#comment-16256633
]
Konstantinos Karanasos commented on YARN-7448:
----------------------------------------------
Please find some quick comments (for v7 of the patch) below.
In AllocateRequest:
* setSchedulingRequests seems to do nothing at the moment
* all other methods of this class are abstract; builders are then used to call
the getters and setters. Is there a reason we chose to do it differently for
the get/setSchedulingRequests?
* methods schedulingRequests and schedulingRequestList seem identical?
I think the equals and the hashcode should be implemented in the
SchedulingRequest and not the SchedulingRequestPBImpl
Let's add a simple test that creates an allocate request with
SchedulingRequests instead of ResourceRequests.
> [API] Add SchedulingRequest to the AllocateRequest
> --------------------------------------------------
>
> Key: YARN-7448
> URL: https://issues.apache.org/jira/browse/YARN-7448
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Panagiotis Garefalakis
> Attachments: YARN-7448-YARN-6592.001.patch,
> YARN-7448-YARN-6592.002.patch, YARN-7448-YARN-6592.003.patch,
> YARN-7448-YARN-6592.004.patch, YARN-7448-YARN-6592.005.patch,
> YARN-7448-YARN-6592.006.patch, YARN-7448-YARN-6592.007.patch
>
>
> YARN-6594 introduces the {{SchedulingRequest}}. This JIRA tracks the
> inclusion of the SchedulingRequest into the AllocateRequest.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
