[
https://issues.apache.org/jira/browse/YARN-7448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257245#comment-16257245
]
Konstantinos Karanasos commented on YARN-7448:
----------------------------------------------
[~asuresh], I see your points regarding the abstract methods and the equals. We
can further discuss this offline, but if we have reached consensus that this
should be the way to do it across the project, then it's fine with me (that's
what I was trying to make sure).
Re: the test, I saw the existing one -- I was talking about an extra one to
show better the usage of the new methods through the AMRMClient, so that
somebody that looks at those tests can see the new API. But it can wait.
Current patch looks good to me. Thanks for the work, [~asuresh] and [~pgaref]!
> [API] Add SchedulingRequest to the AllocateRequest
> --------------------------------------------------
>
> Key: YARN-7448
> URL: https://issues.apache.org/jira/browse/YARN-7448
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Panagiotis Garefalakis
> Attachments: YARN-7448-YARN-6592.001.patch,
> YARN-7448-YARN-6592.002.patch, YARN-7448-YARN-6592.003.patch,
> YARN-7448-YARN-6592.004.patch, YARN-7448-YARN-6592.005.patch,
> YARN-7448-YARN-6592.006.patch, YARN-7448-YARN-6592.007.patch,
> YARN-7448-YARN-6592.008.patch, YARN-7448-YARN-6592.009.patch
>
>
> YARN-6594 introduces the {{SchedulingRequest}}. This JIRA tracks the
> inclusion of the SchedulingRequest into the AllocateRequest.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
