[ https://issues.apache.org/jira/browse/YARN-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285787#comment-16285787 ]
Wilfred Spiegelenburg commented on YARN-7556: --------------------------------------------- You have fixed the points I raised, that is looking good. No further comments on that, +1 on the code changes One last nit is that the documentation for {{maxChildResources}} is out sync with the {{minResources}} and {{maxResources}}: the child resources also use the new resource specification not just the old ones I assume. > Fair scheduler configuration should allow resource types in the minResources > and maxResources properties > -------------------------------------------------------------------------------------------------------- > > Key: YARN-7556 > URL: https://issues.apache.org/jira/browse/YARN-7556 > Project: Hadoop YARN > Issue Type: Sub-task > Components: fairscheduler > Affects Versions: 3.0.0-beta1 > Reporter: Daniel Templeton > Assignee: Daniel Templeton > Priority: Critical > Attachments: YARN-7556.001.patch, YARN-7556.002.patch, > YARN-7556.003.patch, YARN-7556.004.patch, YARN-7556.005.patch, > YARN-7556.006.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org