[ https://issues.apache.org/jira/browse/YARN-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297353#comment-16297353 ]
Konstantinos Karanasos commented on YARN-7670: ---------------------------------------------- Thanks [~asuresh]. I prefer the boolean you added to the tryCommit in this version of the patch. I would keep a version of the tryCommit without the boolean (calling the new one with true) to make clear what the default way of using it should be. +1, once you do that and fix the checkstyle/unit test issues. > Modifications to the ResourceScheduler to support SchedulingRequests > -------------------------------------------------------------------- > > Key: YARN-7670 > URL: https://issues.apache.org/jira/browse/YARN-7670 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Arun Suresh > Assignee: Arun Suresh > Attachments: YARN-7670-YARN-6592.001.patch, > YARN-7670-YARN-6592.002.patch > > > As per discussions in YARN-7612. This JIRA tracks the changes to the > ResourceScheduler interface and implementation in CapacityScheduler to > support SchedulingRequests -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org