[
https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Panagiotis Garefalakis updated YARN-7682:
-----------------------------------------
Attachment: YARN-7682-YARN-6592.004.patch
[~kkaranasos] Thanks for the comments!
bq. I think that the functions you push in the getNodeCardinalityByOp should be
reversed
Agreed, its safer to use the max operator for the minScopeCardility and the min
for the maxScopeCardinality.
bq. Do we need the line right after the comment “// Make sure Anti-affinity
satisfies hard upper limit”?
We actually do because antiAffinity is the only case we need equality min=0 and
max=0.
In the rest of the cases, max is the upper limit i.e. less than 5 containers in
the scope.
This above line allows us to use the same check for all constraints:
{code:java}
minScopeCardinality >= sc.getMinCardinality()
&& maxScopeCardinality < sc.getMaxCardinality()
{code}
Also Including more detailed javadocs in the latest patch v004
> Expose canAssign method in the PlacementConstraintManager
> ---------------------------------------------------------
>
> Key: YARN-7682
> URL: https://issues.apache.org/jira/browse/YARN-7682
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Panagiotis Garefalakis
> Attachments: YARN-7682-YARN-6592.001.patch,
> YARN-7682-YARN-6592.002.patch, YARN-7682-YARN-6592.003.patch,
> YARN-7682-YARN-6592.004.patch, YARN-7682.wip.patch
>
>
> As per discussion in YARN-7613. Lets expose {{canAssign}} method in the
> PlacementConstraintManager that takes a sourceTags, applicationId,
> SchedulerNode and AllocationTagsManager and returns true if constraints are
> not violated by placing the container on the node.
> I prefer not passing in the SchedulingRequest, since it can have > 1
> numAllocations. We want this api to be called for single allocations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
