[ https://issues.apache.org/jira/browse/YARN-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331812#comment-16331812 ]
Konstantinos Karanasos commented on YARN-7763: ---------------------------------------------- A couple of things by a quick look in the patch: * In the canSatisfyConstraints, probably we should do an instanceof SingleConstraint before the cast (and we can explicitly say in the TODO that we don't handle CompositeConstraints – we say generally other constraints) * Not sure about the constraint priority. If I have a global constraint (by the cluster operator), I want to override the app constraint and I want the app constraint to override the specific scheduling request constraint. Eventually we should merge such constraints if possible, but for the time being, I think that should be the priority. Right now it is the other way around. > Allow Constraints specified in the SchedulingRequest to override application > level constraints > ---------------------------------------------------------------------------------------------- > > Key: YARN-7763 > URL: https://issues.apache.org/jira/browse/YARN-7763 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Wangda Tan > Assignee: Weiwei Yang > Priority: Blocker > Attachments: YARN-7763-YARN-6592.001.patch, > YARN-7763-YARN-6592.002.patch, YARN-7763-YARN-6592.003.patch > > > As I mentioned on YARN-6599, we will add SchedulingRequest as part of the > PlacementConstraintUtil method and both of processor/scheduler implementation > will use the same logic. The logic looks like: > {code:java} > PlacementConstraint pc = schedulingRequest.getPlacementConstraint(); > If (pc == null) { > pc = > PlacementConstraintMgr.getPlacementConstraint(schedulingRequest.getAllocationTags()); > } > // Do placement constraint match ...{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org