[ 
https://issues.apache.org/jira/browse/YARN-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331979#comment-16331979
 ] 

Konstantinos Karanasos commented on YARN-7763:
----------------------------------------------

Thanks [~cheersyang]. Only one minor thing: the instanceof check has to be done 
after we call the transformer. If we do it before, it might be a 
CardinalityConstraint or a TargetConstraint, all of which get transformed to a 
SingleConstraint. So we have to do it just right before the cast. Sorry for not 
clarifying it properly.

> Allow Constraints specified in the SchedulingRequest to override application 
> level constraints
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-7763
>                 URL: https://issues.apache.org/jira/browse/YARN-7763
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Weiwei Yang
>            Priority: Blocker
>         Attachments: YARN-7763-YARN-6592.001.patch, 
> YARN-7763-YARN-6592.002.patch, YARN-7763-YARN-6592.003.patch, 
> YARN-7763-YARN-6592.004.patch
>
>
> As I mentioned on YARN-6599, we will add SchedulingRequest as part of the 
> PlacementConstraintUtil method and both of processor/scheduler implementation 
> will use the same logic. The logic looks like:
> {code:java}
> PlacementConstraint pc = schedulingRequest.getPlacementConstraint();
> If (pc == null) {
>   pc = 
> PlacementConstraintMgr.getPlacementConstraint(schedulingRequest.getAllocationTags());
> }
> // Do placement constraint match ...{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to