[ 
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355282#comment-16355282
 ] 

Weiwei Yang commented on YARN-7871:
-----------------------------------

Hi [~sunilg]

Thanks for reviewing this patch.

bq. It could be possible that there are some static configs for any node and 
some additional attributes could be later added from scripts?

Well, I think it is possible, but not a very common scenario.  Most case should 
be using the script path, if user wants to add, they can do so via CLI/REST. 
(we have a similar system here running in such mode happily for years).

bq. We could through an error when config/scripts is not given correct
This is handling the case user configured with a customized implementation of 
{{NodeAttributesProvider}}, just like what node labels provider supports.

bq. Is RMNodeAttributesManager need to part of this jira? 
This is like a placeholder, I discussed with [~naganarasimha...@apache.org] 
earlier that he is fine that I can add a simple API so I can continue my work, 
otherwise I keep being blocked by YARN-6858. We need a in-memory implementation 
of the attribute manager in RM for testing anyway.

> Node attributes reporting from NM to RM 
> ----------------------------------------
>
>                 Key: YARN-7871
>                 URL: https://issues.apache.org/jira/browse/YARN-7871
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Major
>         Attachments: YARN-7871-YARN-3409.001.patch
>
>
> Support to initialize proper attribute provider based on user's configuration.
> NM collects node attributes from a configured attribute provider and send 
> them to RM via HB. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to