[ 
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382973#comment-16382973
 ] 

Naganarasimha G R commented on YARN-7871:
-----------------------------------------

Thanks for the patch [~cheersyang], 

Just skimmed through the patch, few high level comments :
 * do we require 2 methods of replace ? i think even from CLI replace should 
not replace everything hence was thinking of having a single api same as 
earlier except for taking additional param prefix
 * NMDistributedNodeLabelsHandler earlier used to ensure that the labels were 
not sent across repeatatively in every heartbeat. I think we require that more 
here with attributes rather than labels ?

> Node attributes reporting from NM to RM 
> ----------------------------------------
>
>                 Key: YARN-7871
>                 URL: https://issues.apache.org/jira/browse/YARN-7871
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Major
>         Attachments: YARN-7871-YARN-3409.001.patch, 
> YARN-7871-YARN-3409.002.patch
>
>
> Support to initialize proper attribute provider based on user's configuration.
> NM collects node attributes from a configured attribute provider and send 
> them to RM via HB. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to