[
https://issues.apache.org/jira/browse/YARN-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433193#comment-16433193
]
Naganarasimha G R commented on YARN-8104:
-----------------------------------------
Thanks for the patch [~bibinchundatt]
At high level
* Can you inform why NodeToAttributesProto is moved from
yarn_server_resourcemanager_service_protos.proto to yarn_protos.proto ?
* Also would it make sense to provide overloaded method(getNodesToAttributes)
here supporting for NodeID ?
and few other comments :
yarn_protos.protos
* ln no 391: node => hostname ... similar to earlier naming convention
yarn_service_protos.protos
* ln no 282: nodeToAttributes => nodesToAttributes ... based on convention
followed in other places
GetNodesToAttributesRequest.java
* line no 55 & 64 : setNodes & getNodes -> setHostNames & getHostNames
GetNodesToAttributesRequestPBImpl
* line no 120: initNodeAttributes => initNodesToAttributesRequest or just init
* line no 126: nodeLabelsList => hostNamesList
TestPBImplRecords
* We need to invoke generateByNewInstance for all the new PB's in setup. can
you please check.
NodeAttributesManagerImpl
* ln no 454-457: Here we do not have a mapping we are setting a hostname with
empty set, is that better or just pass for the ones which have attributes is
better?
IMO for the ones having mapping is better so that we not bloating the response
and its a map. Also if nonexistent of erroneous hostnames are given it still
shows empty set
TestClientRMService
* ln no 2053: can we have a separate method to test node to attributes API ?
or document what all api's will be tested. and rename it to
testNodeAttributesQueryAPI... i would still prefer the former option itself
though..
Can you also check the new findbug issue reported, checktyle and as well as
the javadoc issues reported, as it seems related to patch and fixable ?
> Add API to fetch node to attribute mapping
> ------------------------------------------
>
> Key: YARN-8104
> URL: https://issues.apache.org/jira/browse/YARN-8104
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-8104-YARN-3409.001.patch,
> YARN-8104-YARN-3409.002.patch, YARN-8104-YARN-3409.003.patch
>
>
> Add node/host to attribute mapping in yarn client API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
