[
https://issues.apache.org/jira/browse/YARN-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433451#comment-16433451
]
Bibin A Chundatt commented on YARN-8104:
----------------------------------------
Thank you [~Naganarasimha] for review
{quote}
Can you inform why NodeToAttributesProto is moved from
yarn_server_resourcemanager_service_protos.proto to yarn_protos.proto
{quote}
GetNodesToAttributesResponseProto yarn_service.proto requires the same
yarn_protos.
{quote}
Also would it make sense to provide overloaded method(getNodesToAttributes)
here supporting for NodeID ?
{quote}
Currently IMHO don't make sense since NodeAttributeManagerImpl doesn't use
NodeId. We can take up this point once we support in NodeAttributeManager.
{quote}
We need to invoke generateByNewInstance for all the new PB's in setup. can you
please check.
{quote}
PB's are added as part of {{testGetNodesToAttributesRequestPBImpl}} and
{{testGetNodesToAttributesResponsePBImpl}}
{quote}
GetNodesToAttributesRequestPBImpl
{quote}
Handled.
{quote}
NodeAttributesManagerImpl
Here we do not have a mapping we are setting a hostname with empty set, is that
better or just pass for the ones which have attributes is better?
{quote}
Avoiding for which attribute mapping are not set.
{quote}
TestClientRMService
{quote}
Separated testcase for each.
Handled javadoc and checkstyle issues too.
> Add API to fetch node to attribute mapping
> ------------------------------------------
>
> Key: YARN-8104
> URL: https://issues.apache.org/jira/browse/YARN-8104
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Major
> Attachments: YARN-8104-YARN-3409.001.patch,
> YARN-8104-YARN-3409.002.patch, YARN-8104-YARN-3409.003.patch,
> YARN-8104-YARN-3409.004.patch
>
>
> Add node/host to attribute mapping in yarn client API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
