[
https://issues.apache.org/jira/browse/YARN-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477826#comment-16477826
]
Haibo Chen commented on YARN-4599:
----------------------------------
+1 on the latest patch, pending one minor comments.
In getDefaultOOMHandler(), the flag that stipulates whether DefaultOOMHandler
is supposed to check virtual memory is hardcoded to false. This should be
dependent on controlPhysicalMemory or controlVirtualMemory. We can move the
assignment of the oomHandler after controlPhysicalMemory and
controlVirtualMemory is initialized. Hence I'd also echo Szilard's previous
comment, we can combine
" Runnable oomHandlerTemp =getDefaultOOMHandler(conf, context,
oomHandlerOverride); this.oomHandler = oomHandlerTemp"
with this.oomHandler = getDefaultOOMHandler(conf, context, oomHandlerOverride,
controlVirtualMemory);
> Set OOM control for memory cgroups
> ----------------------------------
>
> Key: YARN-4599
> URL: https://issues.apache.org/jira/browse/YARN-4599
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 2.9.0
> Reporter: Karthik Kambatla
> Assignee: Miklos Szegedi
> Priority: Major
> Labels: oct16-medium
> Attachments: Elastic Memory Control in YARN.pdf, YARN-4599.000.patch,
> YARN-4599.001.patch, YARN-4599.002.patch, YARN-4599.003.patch,
> YARN-4599.004.patch, YARN-4599.005.patch, YARN-4599.006.patch,
> YARN-4599.007.patch, YARN-4599.008.patch, YARN-4599.009.patch,
> YARN-4599.010.patch, YARN-4599.011.patch, YARN-4599.sandflee.patch,
> yarn-4599-not-so-useful.patch
>
>
> YARN-1856 adds memory cgroups enforcing support. We should also explicitly
> set OOM control so that containers are not killed as soon as they go over
> their usage. Today, one could set the swappiness to control this, but
> clusters with swap turned off exist.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
