[
https://issues.apache.org/jira/browse/YARN-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478004#comment-16478004
]
Miklos Szegedi commented on YARN-4599:
--------------------------------------
[~snemeth], thanks for the review.
oomHandlerTemp is necessary since we may throw an exception after we set it. An
external code optimized by JVM (setting a variable before the constructor is
finished) may get a partial copy of this object in case of the exception. It is
better to set the fields after the exception is not thrown.
3) This code has to be very fast do the same conversion for 1000s of containers
potentially, so I will keep the plain multiplication instead of calling int
external code that deals with strings.
> Set OOM control for memory cgroups
> ----------------------------------
>
> Key: YARN-4599
> URL: https://issues.apache.org/jira/browse/YARN-4599
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Affects Versions: 2.9.0
> Reporter: Karthik Kambatla
> Assignee: Miklos Szegedi
> Priority: Major
> Labels: oct16-medium
> Attachments: Elastic Memory Control in YARN.pdf, YARN-4599.000.patch,
> YARN-4599.001.patch, YARN-4599.002.patch, YARN-4599.003.patch,
> YARN-4599.004.patch, YARN-4599.005.patch, YARN-4599.006.patch,
> YARN-4599.007.patch, YARN-4599.008.patch, YARN-4599.009.patch,
> YARN-4599.010.patch, YARN-4599.011.patch, YARN-4599.sandflee.patch,
> yarn-4599-not-so-useful.patch
>
>
> YARN-1856 adds memory cgroups enforcing support. We should also explicitly
> set OOM control so that containers are not killed as soon as they go over
> their usage. Today, one could set the swappiness to control this, but
> clusters with swap turned off exist.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
