[ 
https://issues.apache.org/jira/browse/YARN-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766162#comment-13766162
 ] 

Karthik Kambatla commented on YARN-1027:
----------------------------------------

bq. Should createAndInit/Start/Stop methods in RM be synchronized? Can they 
race with other activity in the RM happening on the dispatcher thread?
stop() is equivalent to stopping the RM previously. createAndInit/start also 
don't change the behavior in any way. Their callers themselves are 
synchronized, so I don't see the need to synchronize these as well.

bq. Was getClusterTimeStamp() addition necessary? Its good to keep refactorings 
separate.
Filed another subtask under YARN-149 to address this.

Fixed all other comments.

Running a pseudo-cluster with YARN-1068 applied - will update here on the 
scenarios shortly.
                
> Implement RMHAProtocolService
> -----------------------------
>
>                 Key: YARN-1027
>                 URL: https://issues.apache.org/jira/browse/YARN-1027
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Karthik Kambatla
>         Attachments: test-yarn-1027.patch, yarn-1027-1.patch, 
> yarn-1027-2.patch, yarn-1027-3.patch, yarn-1027-4.patch, yarn-1027-5.patch, 
> yarn-1027-6.patch, yarn-1027-7.patch, yarn-1027-including-yarn-1098-3.patch, 
> yarn-1027-in-rm-poc.patch
>
>
> Implement existing HAServiceProtocol from Hadoop common. This protocol is the 
> single point of interaction between the RM and HA clients/services.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to