[ 
https://issues.apache.org/jira/browse/YARN-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767372#comment-13767372
 ] 

Bikas Saha commented on YARN-1027:
----------------------------------

+    // TODO (YARN-1192): Update this post addition of STOPPING state to
Is this still needed since I see that HADOOP-9945 is already committed?

Changes look good to me. Will wait for some time for other folks to take a look.

Looks like not all the memory was reclaimed upon Active->Standby. One thing to 
check would be if the memory keeps increasing after every transition for 
multiple transitions. Another thing would be if the increase is proportional to 
the original memory. Given that the RM was at ~30MB, 3MB might end up being 
noise. E.g. there might be a lot of node state that leaks but the job state is 
GC'd (so large clusters will show bad leaks). OR it might be that job state 
leaks but node state gets deleted (so long running RM restart will show bad 
leaks).  
                
> Implement RMHAProtocolService
> -----------------------------
>
>                 Key: YARN-1027
>                 URL: https://issues.apache.org/jira/browse/YARN-1027
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Karthik Kambatla
>         Attachments: test-yarn-1027.patch, yarn-1027-1.patch, 
> yarn-1027-2.patch, yarn-1027-3.patch, yarn-1027-4.patch, yarn-1027-5.patch, 
> yarn-1027-6.patch, yarn-1027-7.patch, yarn-1027-7.patch, yarn-1027-8.patch, 
> yarn-1027-including-yarn-1098-3.patch, yarn-1027-in-rm-poc.patch
>
>
> Implement existing HAServiceProtocol from Hadoop common. This protocol is the 
> single point of interaction between the RM and HA clients/services.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to