[ https://issues.apache.org/jira/browse/YARN-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542805#comment-16542805 ]
Szilard Nemeth commented on YARN-8524: -------------------------------------- Thanks [~sunilg] for your comments. 1. I still used a primitive long argument as I want to accept ints as well, so Long.valueOf(..).intValue() had to be used. 2. Good point, testcase is added. Thanks! > Single parameter Resource / LightWeightResource constructor looks confusing > --------------------------------------------------------------------------- > > Key: YARN-8524 > URL: https://issues.apache.org/jira/browse/YARN-8524 > Project: Hadoop YARN > Issue Type: Improvement > Components: api > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-8524.001.patch, YARN-8524.002.patch, > YARN-8524.003.patch > > > The single parameter (long) constructor in Resource / LightWeightResource > sets all resource components to the same value. > Since there are other constructors in these classes with (long, int) > parameters where the semantics are different, it could be confusing for the > users. > The perfect place to create such a resource would be in the Resources class, > with a method named like "createResourceWithSameValue". -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org