[
https://issues.apache.org/jira/browse/YARN-8524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545534#comment-16545534
]
Wangda Tan commented on YARN-8524:
----------------------------------
Thanks [~snemeth] for the patch, LGTM too. Will commit soon.
> Single parameter Resource / LightWeightResource constructor looks confusing
> ---------------------------------------------------------------------------
>
> Key: YARN-8524
> URL: https://issues.apache.org/jira/browse/YARN-8524
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: api
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-8524.001.patch, YARN-8524.002.patch,
> YARN-8524.003.patch
>
>
> The single parameter (long) constructor in Resource / LightWeightResource
> sets all resource components to the same value.
> Since there are other constructors in these classes with (long, int)
> parameters where the semantics are different, it could be confusing for the
> users.
> The perfect place to create such a resource would be in the Resources class,
> with a method named like "createResourceWithSameValue".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
