[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553691#comment-16553691
]
Naganarasimha G R commented on YARN-7863:
-----------------------------------------
Have done just a first pass review,
few higher level comments :
# I think Distributed shell related modifications can be pulled into separate
Jira (YARN-8289) as discussed earlier
# I could not get in the meeting wrt to Attributes and Partitions/labels, IIUC
in ResourceRequest we specify the label expression directly but in
SchedulingRequest we can give it as part of PlacementConstraint ? And if so we
club it with the attribute expression ? May be we need capture that explicitly
over here.can you share a sample request with both of them available?
# Attach the doc which captured our conclusions on the expression or capture
the essense of it as Jira's descritpion
Other minor aspects:
* PlacementConstraints.java ln 52- 53, better to use
NodeAttribute.PREFIX_DISTRIBUTED & PREFIX_CENTRALIZED
* PlacementConstraintParser ln 363-436 NodeConstraintsTokenizer seems to be
not used anywhere ?
* ResourceManager ln no 652-654 createNodeAttributesManager should either
return NodeAttributesManagerImpl or take parameter as rmContext instead of type
casting
* .bowerrc ln no 3, might not be related to this patch ?
* TestPlacementConstraintParser : captures a single test case , we need to
capture more examples of capturing the positive and negative expression
validation cases
* TestPlacementConstraintParser ln no 457 : is this the approach which we
finalised ? i thought its much more expressive like the document in
PlacementConstraintParser.parsePlacementSpecForAttributes
As well change the status of the Jira to patch submitted so that jenkins build
will be triggered.
> Modify placement constraints to support node attributes
> -------------------------------------------------------
>
> Key: YARN-7863
> URL: https://issues.apache.org/jira/browse/YARN-7863
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sunil Govindan
> Assignee: Sunil Govindan
> Priority: Major
> Attachments: YARN-7863-YARN-3409.002.patch, YARN-7863.v0.patch
>
>
> This Jira will track to *Modify existing placement constraints to support
> node attributes.*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
