[
https://issues.apache.org/jira/browse/YARN-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577644#comment-16577644
]
Naganarasimha G R commented on YARN-7863:
-----------------------------------------
Thanks for the patch [~sunilg] and apologies for the delayed review, as i was
not acquainted with Placement Constraint part of the code, i required some time
in understanding the placement constraints and then in relation how you have
modified it. But still could not figure out few of the stuff
* Not completely clear sure how the parsing happens for the *And* and *Or*
cases which was mentioned by [~cheersyang] in his earlier comment
"_-placement_spec
OR(IN,python=true:NOTIN,java=1.8):IN,os!=centos:NOTIN,env=prod,dev"_
Just tried to replace the same in your test case but seems like it fails at
PlacementConstraintParser.parseNodeAttributeExpression ln no 669. Whether its
expected to fail or it should assume it as *And* and proceed?
* In PlacementConstraintParser.NodeConstraintParser.parse() PlacementTargets
target in ln no 399 seems to include keys also in val. Was not sure why we
need to store in this way, would it not be bettert only values here
* Can we place both constraints related to attributes and allocation tags
together in a single placement spec for distributed shell? As I understand the
Placement spec API supports to take multiple type of placement constraints for
a single resource/allocation request. We too should support it right ?
* NodeConstraintParser.parse seems to assume that attributeNameSpace has
"rm.yarn.io/" but IIRC we concluded that user need to specify this explicitly
right else exception is thrown right ?
some minor comments
* TestPlacementConstraintParser ln no 453 : testParseNodeAttributeSpec has
attributeName1, attributeName2; which is unused
* ResourceManager ln no 652-654 createNodeAttributesManager should either
return NodeAttributesManagerImpl or take parameter as rmContext instead of type
casting
* Seems like build seems to have find bugs and test case failures. Can you
please have a look at it ?
> Modify placement constraints to support node attributes
> -------------------------------------------------------
>
> Key: YARN-7863
> URL: https://issues.apache.org/jira/browse/YARN-7863
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sunil Govindan
> Assignee: Sunil Govindan
> Priority: Major
> Attachments: YARN-7863-YARN-3409.002.patch,
> YARN-7863-YARN-3409.003.patch, YARN-7863-YARN-3409.004.patch,
> YARN-7863.v0.patch
>
>
> This Jira will track to *Modify existing placement constraints to support
> node attributes.*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
