[ https://issues.apache.org/jira/browse/YARN-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562135#comment-16562135 ]
Rohith Sharma K S commented on YARN-8418: ----------------------------------------- thanks Bibin for clarifying it. Only concern is does InvalidToken exception will be there always in cause? Do you have any log trace corresponding to this? {code:java} // add to disabled aggregators if due to InvalidToken 259 if (e.getCause() instanceof SecretManager.InvalidToken) { 260 invalidTokenApps.add(appId); 261 } {code} nits: # Add a log message with app-id in exception checkAndEnableAppAggregators. It is ignores for all invalid token apps. > App local logs could leaked if log aggregation fails to initialize for the app > ------------------------------------------------------------------------------ > > Key: YARN-8418 > URL: https://issues.apache.org/jira/browse/YARN-8418 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.8.0, 3.0.0-alpha1 > Reporter: Bibin A Chundatt > Assignee: Bibin A Chundatt > Priority: Critical > Attachments: YARN-8418.001.patch, YARN-8418.002.patch, > YARN-8418.003.patch, YARN-8418.004.patch, YARN-8418.005.patch, > YARN-8418.006.patch, YARN-8418.007.patch, YARN-8418.008.patch > > > If log aggregation fails init createApp directory container logs could get > leaked in NM directory > For log running application restart of NM after token renewal this case is > possible/ Application submission with invalid delegation token -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org