[
https://issues.apache.org/jira/browse/YARN-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561188#comment-16561188
]
Wangda Tan commented on YARN-8418:
----------------------------------
Thanks [~bibinchundatt] for updating the patch and [~suma.shivaprasad] for code
review.
One minor comments:
ContainerManagerImpl#handleCredentialUpdate, instead of calling following
logic:
{code}
Set<ApplicationId> invalidTokenApps = logHandler.getInvalidTokenApps();
for (ApplicationId app : invalidTokenApps) {
if (context.getSystemCredentialsForApps().get(app) != null) {
dispatcher.getEventHandler()
.handle(new LogHandlerTokenUpdatedEvent(app));
}
}
{code}
Is it better to just send a LogHandlerTokenUpdatedEvent to log handler (but no
need to specify app id). And inside LogHandler, loop the invalidTokenApps, and
update token.
Benefits of doing this:
- ContainerManagerImpl doesn't have to know about invalid apps, better
encapsulation.
- Avoid race condition that app get added to invalidApps while looping apps
from handleCredentialUpdate.
> App local logs could leaked if log aggregation fails to initialize for the app
> ------------------------------------------------------------------------------
>
> Key: YARN-8418
> URL: https://issues.apache.org/jira/browse/YARN-8418
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.8.0, 3.0.0-alpha1
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Critical
> Attachments: YARN-8418.001.patch, YARN-8418.002.patch,
> YARN-8418.003.patch, YARN-8418.004.patch, YARN-8418.005.patch,
> YARN-8418.006.patch, YARN-8418.007.patch
>
>
> If log aggregation fails init createApp directory container logs could get
> leaked in NM directory
> For log running application restart of NM after token renewal this case is
> possible/ Application submission with invalid delegation token
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
