[
https://issues.apache.org/jira/browse/YARN-7948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564049#comment-16564049
]
Haibo Chen commented on YARN-7948:
----------------------------------
Thanks [~snemeth] for updating the patch. I have a few follow up comments.
For the custom ResourceTypeConfigurationProvider, I wonder if it is more
readable to either set the properties directly with Configuration.set()
(Capacity Scheduler unit test does this right) or even better, call
Configuration.addResource(). We can get rid of the special parameter matching
too.
We don't do anything with resource manager in
{{TestFairSchedulerWithMultiResourceTypes}}, so we can get rid of anything that
is related to resource manager. Given cpu and memory are default resource
types, we should cover them too in unit tests.
There are a few unused imports in TestFairScheduler that need to cleaned up.
> Enable refreshing maximum allocation for multiple resource types
> ----------------------------------------------------------------
>
> Key: YARN-7948
> URL: https://issues.apache.org/jira/browse/YARN-7948
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 3.0.0
> Reporter: Yufei Gu
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-7948.001.patch, YARN-7948.002.patch
>
>
> YARN-7738 did the same thing for CS. We need a fix for FS. We could fix it by
> moving the refresh code from class CS to class AbstractYARNScheduler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
