[
https://issues.apache.org/jira/browse/YARN-7948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565579#comment-16565579
]
Haibo Chen commented on YARN-7948:
----------------------------------
There are a couple of newly added import statements in TestFairScheduler.
Because there is no code change, those import statements are unused and
therefore can be removed.
{quote}Default resources (cpu, memory) are already covered in my testcase in
patch002 so I haven't modified this part.
{quote}
Indeed. My apologies for missing that.
While not a strict requirement, given that the vast majority of the code base
uses 4 spaces as line continuation, it'd be nice to keep the style consistent.
Otherwise, the patch looks fine to me.
> Enable refreshing maximum allocation for multiple resource types
> ----------------------------------------------------------------
>
> Key: YARN-7948
> URL: https://issues.apache.org/jira/browse/YARN-7948
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 3.0.0
> Reporter: Yufei Gu
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: YARN-7948.001.patch, YARN-7948.002.patch,
> YARN-7948.003.patch
>
>
> YARN-7738 did the same thing for CS. We need a fix for FS. We could fix it by
> moving the refresh code from class CS to class AbstractYARNScheduler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
