[ https://issues.apache.org/jira/browse/YARN-7865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594805#comment-16594805 ]
Bibin A Chundatt commented on YARN-7865: ---------------------------------------- Thank you [~Naganarasimha] for posting patch. Few comments # Notes node label is used {quote}If user want to store node label to local file system of RM, paths like [file:///home/yarn/node-label] can be used else if in hdfs paths like hdfs://namenode:port/path/to/store/node-attributes/ can be used {quote} # We replace the attributes on that particular node rt ?? Could you check the same. {quote}Unlike labels, attributes can be mapped to a node from both Centralised and Distributed modes at the same time. There will be no clashes as attributes are identified with different prefix in different modes. In case of Centralized attributes are identified by prefix “rm.yarn.io” and in case of Distributed attributes are identified by prefix “nm.yarn.io”. This implies attributes are uniquely identified by prefix and name. {quote} # Better to quote Resourcemanager process user rt ? {quote}(Typically from “yarn” user) {quote} # NodeReport seems coding terms rt?. Better to mention "Node status/detail contains attributes values associated with the node" thoughts?? {quote}NodeReport got from yarn node -status will list all the attributes and its value associated with the node. {quote} > Node attributes documentation > ----------------------------- > > Key: YARN-7865 > URL: https://issues.apache.org/jira/browse/YARN-7865 > Project: Hadoop YARN > Issue Type: Sub-task > Components: documentation > Reporter: Weiwei Yang > Assignee: Naganarasimha G R > Priority: Major > Attachments: NodeAttributes.html, YARN-7865-YARN-3409.001.patch > > > We need proper docs to introduce how to enable node-attributes how to > configure providers, how to specify script paths, arguments in configuration, > what should be the proper permission of the script and who will run the > script. Also it would be good to add more info to the description of the > configuration properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org