[
https://issues.apache.org/jira/browse/YARN-7865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597060#comment-16597060
]
Weiwei Yang commented on YARN-7865:
-----------------------------------
Hi [~Naganarasimha]
Thanks for working on the documentation, it looks really good. Just go over the
doc, I have following comments/suggestions:
(1) *Distributed node-to-Attributes mapping*
There are two rows describing
{{yarn.nodemanager.node-attributes.provider.fetch-timeout-ms}}, the first one
should be replaced by
{{yarn.nodemanager.node-attributes.provider.fetch-interval-ms}} correct? The
description seems to be saying the interval, not timeout.
(2) *Specifying node attributes for application*
It would be nice if we add some explanation right after the java code sample.
Something like:
{noformat}
The above SchedulingRequest applies 1 container on nodes that must satisfy
following constraints:
1) Node attribute rm.yarn.io/python doesn't exist on the node or it exist but
its value is not equal to 3
2) Node attribute rm.yarn.io/java must exist on the node and its value is equal
to 1.8
{noformat}
BTW, can we rename the variable {{schedulingRequest1}} to just
{{schedulingRequest}} in this example?
(3) It will also be good if we mention node attribtue constraints are HARD
limits, something like
{noformat}
Node attribute constraints are hard limits, that says the allocation can only
be made if the node satisfies the node attribute constraint. In another word,
the request keeps pending until it finds a valid node satisfying the
constraint. There is no relax policy at present.
{noformat}
this can be added to the features section I guess. Feel free to rephrase if you
like.
Thanks
> Node attributes documentation
> -----------------------------
>
> Key: YARN-7865
> URL: https://issues.apache.org/jira/browse/YARN-7865
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: documentation
> Reporter: Weiwei Yang
> Assignee: Naganarasimha G R
> Priority: Major
> Attachments: NodeAttributes.html, YARN-7865-YARN-3409.001.patch,
> YARN-7865-YARN-3409.002.patch, YARN-7865-YARN-3409.003.patch,
> YARN-7865-YARN-3409.004.patch
>
>
> We need proper docs to introduce how to enable node-attributes how to
> configure providers, how to specify script paths, arguments in configuration,
> what should be the proper permission of the script and who will run the
> script. Also it would be good to add more info to the description of the
> configuration properties.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
