[ 
https://issues.apache.org/jira/browse/YARN-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610407#comment-16610407
 ] 

Antal Bálint Steinbach commented on YARN-8759:
----------------------------------------------

Hi [~maniraj...@gmail.com] ,

Thanks for checking the changes. I searched through the codebase looking for 
"resource-types" string and I only found that place where the teardown was 
missing.

I checked the other files in Yarnconfiguration.java and I only found one other 
problematic place with "node-resources.xml". I added a fix for that in the 2nd 
patch.

I do not see any general solution right now. In my opinion, the problem is that 
we run integration like tests in a unit test environment, so we have to do the 
cleanup manually to reset the state between unit tests.

Please let me know if you find any places where cleanup is missing.

> Copy of "resource-types.xml" is not deleted if test fails, causes other test 
> failures
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-8759
>                 URL: https://issues.apache.org/jira/browse/YARN-8759
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>            Reporter: Antal Bálint Steinbach
>            Assignee: Antal Bálint Steinbach
>            Priority: Major
>         Attachments: YARN-8759.001.patch, YARN-8759.002.patch
>
>
> resource-types.xml is copied in several tests to the test machine, but it is 
> deleted only at the end of the test. In case the test fails the file will not 
> be deleted and other tests will fail, because of the wrong configuration.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to