[ https://issues.apache.org/jira/browse/YARN-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614915#comment-16614915 ]
Antal Bálint Steinbach commented on YARN-8759: ---------------------------------------------- Hi [~maniraj...@gmail.com] , Thanks, for your comments. # It is not mandatory, I just set it to null, because there are some test which does not use/set the File field so in the tearDown the null check is faster than the File.exists() call. # In TestRMAdminCLI the _File dest_ field is set up in the test setup method before every test so it does not makes sense to set it to null or do a null check in teardown. > Copy of "resource-types.xml" is not deleted if test fails, causes other test > failures > ------------------------------------------------------------------------------------- > > Key: YARN-8759 > URL: https://issues.apache.org/jira/browse/YARN-8759 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn > Reporter: Antal Bálint Steinbach > Assignee: Antal Bálint Steinbach > Priority: Major > Attachments: YARN-8759.001.patch, YARN-8759.002.patch, > YARN-8759.003.patch > > > resource-types.xml is copied in several tests to the test machine, but it is > deleted only at the end of the test. In case the test fails the file will not > be deleted and other tests will fail, because of the wrong configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org