[
https://issues.apache.org/jira/browse/YARN-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614641#comment-16614641
]
Sunil Govindan commented on YARN-8715:
--------------------------------------
Hi [~cheersyang]
Thanks for the patch
{code:java}
710 // Use global num of containers when the spec doesn't specify
711 // source tags. This is allowed when using node-attribute constraints.
712 if (Strings.isNullOrEmpty(pSpec.sourceTag)
713 && pSpec.getNumContainers() == 0
714 && globalNumOfContainers > 0) {
715 pSpec.setNumContainers(globalNumOfContainers);
716 }{code}
in here, numContainers is set to each spec. So if we have 2 or more specs,
total number of container ll not match and i think DS application wont exit due
to this, cud u pls check once.
{code:java}
727 if (sourceTagSet.stream()
728 .filter(sourceTags -> sourceTags.isEmpty())
729 .findAny()
730 .isPresent()) {{code}
When will this check hit?
> Make allocation tags in the placement spec optional for node-attributes
> -----------------------------------------------------------------------
>
> Key: YARN-8715
> URL: https://issues.apache.org/jira/browse/YARN-8715
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-8715.001.patch
>
>
> YARN-7863 adds support to specify constraints targeting to node-attributes,
> including the support in distributed shell, but it still needs to specify
> {{allocationTags=numOfContainers}} in the spec. We should make this optional
> as it is not required for node-attribute expressions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
