[
https://issues.apache.org/jira/browse/YARN-8715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614657#comment-16614657
]
Weiwei Yang commented on YARN-8715:
-----------------------------------
Hi [~sunilg]
{quote}When will this check hit?
{quote}
If sourceTags (foo=3 field) is not specified in a spec, this check ensures it
must be a SINGLE node-attribute constraint. In another word, expression like
"rm.yarn.io/foo=true:xyz=1,notin,node,xyz" is not allowed (you can take a look
at the test code I added intestParseNodeAttributeSpec). Because such expression
doesn't make much sense. So the convention is:
* If the expression contains multiple specs, then each of them MUST have
sourceTags defined;
* If the expression contains a single spec, the sourceTags can be optional for
node-attribute constraint but enforced for allocation-tag constraint
With this check, we won't run into the problem you mentioned in 1st comment
{quote} So if we have 2 or more specs, total number of container ll not match
and i think DS application wont exit due to this
{quote}
because if they are 2 specs, they must have sourceTags specified. So won't get
reset to "-num_containers".
Hope it makes sense.
Thanks
> Make allocation tags in the placement spec optional for node-attributes
> -----------------------------------------------------------------------
>
> Key: YARN-8715
> URL: https://issues.apache.org/jira/browse/YARN-8715
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Attachments: YARN-8715.001.patch
>
>
> YARN-7863 adds support to specify constraints targeting to node-attributes,
> including the support in distributed shell, but it still needs to specify
> {{allocationTags=numOfContainers}} in the spec. We should make this optional
> as it is not required for node-attribute expressions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
