[
https://issues.apache.org/jira/browse/YARN-8665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622765#comment-16622765
]
Eric Yang commented on YARN-8665:
---------------------------------
[~csingh] Thank you for the patch. Patch 3 works correctly in my tests. A few
nitpicks:
# The new version of the components directory in HDFS is not removed. (i.e.
.yarn/services/abc/components/6) .
# The upgrades directory in HDFS is not removed after cancel. Not sure if this
can cause future problem.
# ServiceTestUtils.java, Comment out code can be removed.
#
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/Container.java
changes is not necessary.
Other than those minor issues, the patch looks good to me.
> Yarn Service Upgrade: Support cancelling upgrade
> -------------------------------------------------
>
> Key: YARN-8665
> URL: https://issues.apache.org/jira/browse/YARN-8665
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Chandni Singh
> Assignee: Chandni Singh
> Priority: Major
> Attachments: YARN-8665.001.patch, YARN-8665.002.patch,
> YARN-8665.003.patch
>
>
> When a service is upgraded without auto-finalization or express upgrade, then
> the upgrade can be cancelled. This provides the user ability to test upgrade
> of a single instance and if that doesn't go well, they get a chance to cancel
> it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
