[
https://issues.apache.org/jira/browse/YARN-8665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622803#comment-16622803
]
Chandni Singh commented on YARN-8665:
-------------------------------------
[~eyang] thanks for review.
About 2
{quote}
The upgrades directory in HDFS is not removed after cancel. Not sure if this
can cause future problem.
{quote}
I am deleting the dir for the cancelled version. Here is the code in
{{ServiceManager}} which gets executed during finalization:
{code}
if (cancelUpgrade) {
fs.deleteClusterUpgradeDir(getName(), cancelledVersion);
} else {
fs.deleteClusterUpgradeDir(getName(), upgradeVersion);
}
{code}
The parent directory {{upgrade}} is not deleted, but that doesn't create any
issue. We create version directories under it, so if {{upgrade}} doesn't exist,
it gets created otherwise just the subdir is created.
I will address rest of the comments in the new patch.
> Yarn Service Upgrade: Support cancelling upgrade
> -------------------------------------------------
>
> Key: YARN-8665
> URL: https://issues.apache.org/jira/browse/YARN-8665
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Chandni Singh
> Assignee: Chandni Singh
> Priority: Major
> Attachments: YARN-8665.001.patch, YARN-8665.002.patch,
> YARN-8665.003.patch
>
>
> When a service is upgraded without auto-finalization or express upgrade, then
> the upgrade can be cancelled. This provides the user ability to test upgrade
> of a single instance and if that doesn't go well, they get a chance to cancel
> it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
