[
https://issues.apache.org/jira/browse/YARN-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685619#comment-16685619
]
Bibin A Chundatt commented on YARN-8898:
----------------------------------------
Thank you [~subru] for providing your views.
{quote}Also, it looks to me that only the ApplicationSubmissionContext (in
non-federated mode) is persisted in the RMStateStore and if there's a update of
an Application priority followed by RM failover, the priority will revert to
the original one at submission?
{quote}
CapacityScheduler#updateApplicationPriority --> updates to state store too.
{code:java}
// Update new priority in Submission Context to update to StateStore.
rmApp.getApplicationSubmissionContext().setPriority(appPriority);
// Update to state store
ApplicationStateData appState = ApplicationStateData.newInstance(
rmApp.getSubmitTime(), rmApp.getStartTime(),
rmApp.getApplicationSubmissionContext(), rmApp.getUser(),
rmApp.getCallerContext());
appState.setApplicationTimeouts(rmApp.getApplicationTimeouts());
rmContext.getStateStore().updateApplicationStateSynchronously(appState,
false, future);
{code}
So the updated one should reflect after restart.
RMAppImpl#RMAppRecoveredTransition recovers timeout. and priority
{quote}Sincerely apologize for the delay as I see you already have a patch with
solution 1.
{quote}
No issues.Was trying out both implementation.
Solution 1 : As discussed earlier by [~botong] AMRMRegistrationResponse is easy
update.
Solution 2 : Too big change as [~botong] mentioned. (Router, StateStore,
AMRMProxy) , new table (mysql).
For _applicationSubmissionContext_ saved by Router will add a trimmed version
of context to stateStore. ContainerLaunchContext --> will remove all except
acls.Hope this is fine ,since it reduces statestore size
Will upload a WIP patch soon with solution 2.
> Fix FederationInterceptor#allocate to set application priority in
> allocateResponse
> ----------------------------------------------------------------------------------
>
> Key: YARN-8898
> URL: https://issues.apache.org/jira/browse/YARN-8898
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bilwa S T
> Priority: Major
> Attachments: YARN-8898.wip.patch
>
>
> In case of FederationInterceptor#mergeAllocateResponses skips
> application_priority in response returned
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
