[ 
https://issues.apache.org/jira/browse/YARN-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693316#comment-16693316
 ] 

Wilfred Spiegelenburg commented on YARN-8738:
---------------------------------------------

Thank you for the patch [~snemeth]. The build has had some issues and the 
findbugs seems to be a resource issue but it would be good to get a full build 
run on it again. I cannot find the failure for the shaded client either.
Since there are some checkstyle issues you could get two things in one go: fix 
the new checkstyle issues and get the build re-run with a new patch.

> FairScheduler configures maxResources or minResources as negative, the value 
> parse to a positive number.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-8738
>                 URL: https://issues.apache.org/jira/browse/YARN-8738
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 3.2.0
>            Reporter: Sen Zhao
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-8738.001.patch
>
>
> If maxResources or minResources is configured as a negative number, the value 
> will be positive after parsing.
> If this is a problem, I will fix it. If not, the 
> FairSchedulerConfiguration#parseNewStyleResource parse negative number should 
> be same with parseOldStyleResource .
> cc:[~templedf], [~leftnoteasy]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to